Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urls -> doi_or_url and returns a list of string #571

Merged
merged 1 commit into from
Feb 28, 2024
Merged

urls -> doi_or_url and returns a list of string #571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/01_atlases_and_parcellations/001_accessing_parcellations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@

# %%
# Also, you can display the doi/url of the related dataset/publication using
print(julich_brain.doi_or_url)
print(julich_brain.urls)

# %%
# Typically however, we are only interested in the parcellations supported by
Expand Down
7 changes: 4 additions & 3 deletions siibra/core/concept.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,12 +125,13 @@ def LICENSE(self) -> str:
return '\n'.join(licenses)

@property
def doi_or_url(self) -> str:
return '\n'.join([
def urls(self) -> List[str]:
"""The list of URLs (including DOIs) associated with this atlas concept."""
return [
url.get("url")
for ds in self.datasets
for url in ds.urls
])
]

@property
def authors(self):
Expand Down
7 changes: 4 additions & 3 deletions siibra/features/feature.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,12 +175,13 @@ def LICENSE(self) -> str:
return '\n'.join(licenses)

@property
def doi_or_url(self) -> str:
return '\n'.join([
def urls(self) -> List[str]:
"""The list of URLs (including DOIs) associated with this feature."""
return [
url.get("url")
for ds in self.datasets
for url in ds.urls
])
]

@property
def authors(self):
Expand Down
Loading