Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cell density profile #617

Merged
merged 1 commit into from
Dec 6, 2024
Merged

fix: cell density profile #617

merged 1 commit into from
Dec 6, 2024

Conversation

AhmetNSimsek
Copy link
Collaborator

Fixes #276 and #509

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 46 lines in your changes missing coverage. Please review.

Project coverage is 46.14%. Comparing base (d250546) to head (e45a688).
Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
siibra/features/tabular/cell_density_profile.py 30.30% 46 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #617      +/-   ##
==========================================
+ Coverage   45.99%   46.14%   +0.15%     
==========================================
  Files          75       75              
  Lines        7234     7171      -63     
==========================================
- Hits         3327     3309      -18     
+ Misses       3907     3862      -45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AhmetNSimsek AhmetNSimsek force-pushed the fix_celldensityprofile branch from 06ad2b5 to 2e7e1ff Compare November 20, 2024 15:10
@AhmetNSimsek AhmetNSimsek force-pushed the fix_celldensityprofile branch 3 times, most recently from 41a377c to 81ad28e Compare December 4, 2024 15:10
@AhmetNSimsek AhmetNSimsek changed the title wip: fix cell density profile fix: cell density profile Dec 4, 2024
@AhmetNSimsek AhmetNSimsek marked this pull request as ready for review December 4, 2024 15:13
@AhmetNSimsek AhmetNSimsek force-pushed the fix_celldensityprofile branch 2 times, most recently from 72d5758 to d296379 Compare December 6, 2024 10:19
@AhmetNSimsek AhmetNSimsek force-pushed the fix_celldensityprofile branch from d296379 to e45a688 Compare December 6, 2024 10:48
@AhmetNSimsek
Copy link
Collaborator Author

Failing tests are due to Allen API so the PR will be merged.

@AhmetNSimsek AhmetNSimsek merged commit 465222d into main Dec 6, 2024
31 of 41 checks passed
@AhmetNSimsek AhmetNSimsek deleted the fix_celldensityprofile branch December 6, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] cannot get boundary_positions for hoc2 right
2 participants