Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise if get_map can't find any maps instead of logging and returning None #618

Merged
merged 4 commits into from
Nov 26, 2024

Conversation

AhmetNSimsek
Copy link
Collaborator

Replaces #460

@AhmetNSimsek AhmetNSimsek added the maintenance Not a bug or breaking issue. Code maintenance related. label Nov 13, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 46.06%. Comparing base (dc63457) to head (b36aa4b).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
siibra/core/parcellation.py 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #618      +/-   ##
==========================================
+ Coverage   46.00%   46.06%   +0.05%     
==========================================
  Files          75       75              
  Lines        7232     7240       +8     
==========================================
+ Hits         3327     3335       +8     
  Misses       3905     3905              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AhmetNSimsek AhmetNSimsek merged commit b1b49c8 into main Nov 26, 2024
39 checks passed
@AhmetNSimsek AhmetNSimsek deleted the maint_get_map_raise branch November 26, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Not a bug or breaking issue. Code maintenance related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant