-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce map.get_volume()
which returns a FilteredVolume
#624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AhmetNSimsek
force-pushed
the
maint_regional_volume
branch
3 times, most recently
from
November 27, 2024 13:18
0046bd2
to
9e38603
Compare
AhmetNSimsek
changed the title
introduce
introduce Dec 4, 2024
map.get_volume()
which returns a RefinedVolume
map.get_volume()
which returns a FilteredVolume
AhmetNSimsek
force-pushed
the
maint_regional_volume
branch
2 times, most recently
from
December 6, 2024 08:22
0651917
to
7039290
Compare
Closed
Dev Meeting 2024-12-06: The PR is a go. Just need to update the tests. |
…lume`s `FilteredVolume` is a volume which can only fetch specific a label and/or a fragment specifications. This enables user to get a volume of a regional mask from a labelled volume without fetching the data to obey lazy fetching design.
AhmetNSimsek
force-pushed
the
maint_regional_volume
branch
from
December 11, 2024 08:15
77ae959
to
7ee8829
Compare
…fetched correctly from FilteredVolumes. Bug fixes.
AhmetNSimsek
force-pushed
the
maint_regional_volume
branch
from
December 11, 2024 16:12
7ee8829
to
099f8ee
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #624 +/- ##
==========================================
- Coverage 46.14% 45.60% -0.54%
==========================================
Files 75 75
Lines 7171 7194 +23
==========================================
- Hits 3309 3281 -28
- Misses 3862 3913 +51 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #554 (comment)
map.fetch()
. New use:region.get_regional_map
only returns the mask of the maps #602.region.get_regional_map
only gets a volume that is mapped in a parcellation map.region.get_regional_mask
gets a volume to use as a mask, and also can combine several child masks to create a mask for parent regions.threshold
only applies toget_regional_mask
and for statistical maps.map.get_volume
which returns aFilteredVolume
.FilteredVolume
can have label, fragment, and threshold specifications to allow for lazy fetching of these specifications and these only.get_regional_mask
always return aFilteredVolume
.get_regional_map
can return aVolume
if the map is defined as an individual volume in the configuration; but they do not have more information like a labelled map volume of julich brain 2.9 on mni152 space.region.get_regional_map
. This was performing a linear transformation and it is not explicit. Deprecated for clarity as users can resample the maps themselves withnilearn
if they'd like.