Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise when a PointSet is initialized empty #627

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

AhmetNSimsek
Copy link
Collaborator

Fixes #621

@AhmetNSimsek AhmetNSimsek added the maintenance Not a bug or breaking issue. Code maintenance related. label Dec 11, 2024
@AhmetNSimsek AhmetNSimsek force-pushed the maint_raise_for_empty_pointset branch from c81b294 to 97f22b7 Compare December 12, 2024 09:04
@AhmetNSimsek AhmetNSimsek marked this pull request as draft December 12, 2024 09:05
@AhmetNSimsek AhmetNSimsek force-pushed the maint_raise_for_empty_pointset branch from ee0a249 to ba32bcd Compare December 12, 2024 12:09
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 56.25000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 46.16%. Comparing base (e45a688) to head (60c20af).
Report is 31 commits behind head on main.

Files with missing lines Patch % Lines
siibra/volumes/parcellationmap.py 0.00% 4 Missing ⚠️
siibra/locations/boundingbox.py 0.00% 2 Missing ⚠️
siibra/locations/pointset.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #627      +/-   ##
==========================================
+ Coverage   46.14%   46.16%   +0.01%     
==========================================
  Files          75       75              
  Lines        7171     7181      +10     
==========================================
+ Hits         3309     3315       +6     
- Misses       3862     3866       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AhmetNSimsek AhmetNSimsek marked this pull request as ready for review December 12, 2024 19:12
@AhmetNSimsek AhmetNSimsek merged commit 7165846 into main Dec 12, 2024
30 of 39 checks passed
@AhmetNSimsek AhmetNSimsek deleted the maint_raise_for_empty_pointset branch December 12, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Not a bug or breaking issue. Code maintenance related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug for bounding box of empty point sets - siibra v1
1 participant