Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default of find_topmost in parcellation.get_region to False #632

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

AhmetNSimsek
Copy link
Collaborator

@AhmetNSimsek AhmetNSimsek commented Dec 13, 2024

fixes #564

@AhmetNSimsek AhmetNSimsek added the maintenance Not a bug or breaking issue. Code maintenance related. label Dec 13, 2024
@AhmetNSimsek AhmetNSimsek self-assigned this Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.48%. Comparing base (4691351) to head (08d9721).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #632      +/-   ##
==========================================
- Coverage   45.61%   45.48%   -0.13%     
==========================================
  Files          75       75              
  Lines        7184     7191       +7     
==========================================
- Hits         3277     3271       -6     
- Misses       3907     3920      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AhmetNSimsek AhmetNSimsek force-pushed the maint_parc_get_region_topmost_behaviour branch from ba777a4 to b6b9ecc Compare December 16, 2024 08:51
@AhmetNSimsek AhmetNSimsek merged commit b615b40 into main Dec 16, 2024
38 of 39 checks passed
@AhmetNSimsek AhmetNSimsek deleted the maint_parc_get_region_topmost_behaviour branch December 16, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Not a bug or breaking issue. Code maintenance related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_region("6ma") returns "posterior medial superior frontal gyrus" instead
1 participant