Added several strings related to chat handling. #271
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kashike
suggested changes
Dec 12, 2018
| @@ -20,4 +22,6 @@ CLASS va net/minecraft/server/network/ServerPlayNetworkHandler | |||
| METHOD a onPlayerInteractBlock (Loo;)V | |||
| METHOD a onPlayerInteractItem (Lop;)V | |||
| METHOD aa_ tick ()V | |||
| METHOD b disconnectWithReason (Ljb;)V | |||
There was a problem hiding this comment.
WithReason is not necessary in the name.
|
As it's tiny and has not been resolved in time, we'll take care of it manually post-update. |
|
Redid these changse for the new update in #282. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Look at my teeny little pull request and tremble in terror.
Since I was working on these lines in order to use a Mixin here, I decided to go ahead and map the lines myself, to make development a bit easier.