23w51b yet more stuff #3756
Merged
23w51b yet more stuff #3756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apple502j
added
refactor
…-yet-more-stuff # Conflicts: # mappings/net/minecraft/block/Fertilizable.mapping # mappings/net/minecraft/client/Mouse.mapping # mappings/net/minecraft/client/gui/hud/ChatHud.mapping # mappings/net/minecraft/client/gui/hud/InGameHud.mapping # mappings/net/minecraft/client/gui/screen/TitleScreen.mapping # mappings/net/minecraft/client/gui/screen/multiplayer/MultiplayerServerListWidget.mapping # mappings/net/minecraft/client/network/ServerInfo.mapping # mappings/net/minecraft/client/render/entity/StriderEntityRenderer.mapping # mappings/net/minecraft/client/util/ParticleUtil.mapping # mappings/net/minecraft/datafixer/fix/BlockNameFix.mapping # mappings/net/minecraft/entity/mob/PiglinEntity.mapping # mappings/net/minecraft/entity/mob/SkeletonHorseEntity.mapping # mappings/net/minecraft/entity/mob/ZombieEntity.mapping # mappings/net/minecraft/entity/mob/ZombieHorseEntity.mapping # mappings/net/minecraft/entity/mob/ZombifiedPiglinEntity.mapping # mappings/net/minecraft/entity/passive/AbstractDonkeyEntity.mapping # mappings/net/minecraft/entity/passive/ChickenEntity.mapping # mappings/net/minecraft/entity/passive/CowEntity.mapping # mappings/net/minecraft/entity/passive/FoxEntity.mapping # mappings/net/minecraft/entity/passive/HorseEntity.mapping # mappings/net/minecraft/entity/passive/LlamaEntity.mapping # mappings/net/minecraft/entity/passive/PandaEntity.mapping # mappings/net/minecraft/entity/passive/TurtleEntity.mapping # mappings/net/minecraft/entity/player/PlayerEntity.mapping # mappings/net/minecraft/item/map/MapState.mapping # mappings/net/minecraft/server/function/FunctionBuilder.mapping # mappings/net/minecraft/server/function/Macro.mapping # mappings/net/minecraft/world/WorldEvents.mapping # mappings/net/minecraft/world/WorldSaveHandler.mapping
|
Conflict resolved, @Shnupbups please make sure to SCREAM. |
apple502j
commented
Dec 20, 2023
Shnupbups
requested changes
Dec 20, 2023
There was a problem hiding this comment.
Whoops, sorry about all the forgetting to use SCREAMING_SNAKE_CASE, I must have been really tired haha. I think with the babyDimensions ones specifically I just started with the AbstractDonkeyEntity one, which isn't static final for some reason and thus camelCase is fine, and assumed others would be the same without looking closely. As for the dateTimeFormatter one... that was just extra sloppy on my part haha.
Shnupbups
approved these changes
Dec 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conflict to be resolved later