Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NON_NEGATIVE spelling convention #3932

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Conversation

Octol1ttle
Copy link
Contributor

Fixes #3647 (Constant strings say "non-negative" so I chose that) and maps a method in IntProvider that validates that the provider's range is within the provided (by the method arguments) range

@apple502j apple502j added refactor A PR that renames existing names. new A PR that maps mainly new names snapshot A PR that targets a snapshot version of Minecraft labels Aug 16, 2024
@apple502j apple502j merged commit 1490b30 into FabricMC:24w33a Aug 16, 2024
6 checks passed
@Octol1ttle Octol1ttle deleted the fix-3647 branch August 16, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new A PR that maps mainly new names refactor A PR that renames existing names. snapshot A PR that targets a snapshot version of Minecraft
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-negative codec field names are inconsistent
2 participants