SnapshotGroup v1, with support for 1.25 #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbren
force-pushed
the
rb/snapshotgroup-v1
branch
from
9459e3c to
1554f0b
Compare
rbren
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #146
Checklist
Description
What's the goal of this PR?
Support k8s 1.25 by updating the Gemini CRD
What changes did you make?
Remove v1beta1 CRD, replace with v1 CRD that supports the new PV spec
What alternative solution should we consider, if any?
Continue supporting v1beta1, but it's a pain to support two versions of the same CRD