Resolve #41: False positive for FakeItEasy0003 when using argument constraint in CallToSet with indexer property #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 19, 2023 23:49
…raint in A.CallToSet and Fake.CallsToSet
…argument constraints. Closes FakeItEasy#41.
blairconrad
approved these changes
Jan 20, 2023
There was a problem hiding this comment.
Looks great to me, @zivarah. Thanks. I appreciate the bonus cleanup (method names, null checks) that you did while you were in the area.
thomaslevesque
approved these changes
Jan 20, 2023
|
Excellent work, thanks @zivarah! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41.
Usage of
A.CallToSet(...)andFake.CallsToSet(...)with an argument constraint will no longer throw FakeItEasy0003 warnings. As far as I am aware, these are only going to be valid when the property specification is an indexer, so those are the test cases I added.Examples:
Please note that I am much less familiar with VB syntax in general, and have never used FakeItEasy with VB, so go easy on me if I messed that part up at all. I have no excuse if I messed up the C# part 😁.