Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Methods are instance methods #708

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Fix: Methods are instance methods #708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Faker/Core/Coordinates.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ public function longitude(float $min = -180.0, float $max = 180.0): float
public function localCoordinates(): array
{
return [
'latitude' => static::latitude(),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See

Faker/src/Faker/Core/Coordinates.php

Lines 16 to 27 in c77a91b

public function latitude(float $min = -90.0, float $max = 90.0): float
{
if ($min < -90 || $max < -90) {
throw new \LogicException('Latitude cannot be less that -90.0');
}
if ($min > 90 || $max > 90) {
throw new \LogicException('Latitude cannot be greater that 90.0');
}
return $this->randomFloat(6, $min, $max);
}

'longitude' => static::longitude(),
'latitude' => $this->latitude(),
'longitude' => $this->longitude(),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See

Faker/src/Faker/Core/Coordinates.php

Lines 34 to 45 in c77a91b

public function longitude(float $min = -180.0, float $max = 180.0): float
{
if ($min < -180 || $max < -180) {
throw new \LogicException('Longitude cannot be less that -180.0');
}
if ($min > 180 || $max > 180) {
throw new \LogicException('Longitude cannot be greater that 180.0');
}
return $this->randomFloat(6, $min, $max);
}

];
}

Expand Down
2 changes: 1 addition & 1 deletion src/Faker/Core/Number.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public function randomDigit(): int

public function randomDigitNot(int $except): int
{
$result = self::numberBetween(0, 8);
$result = $this->numberBetween(0, 8);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See

Faker/src/Faker/Core/Number.php

Lines 14 to 20 in 6c3a043

public function numberBetween(int $min = 0, int $max = 2147483647): int
{
$int1 = min($min, $max);
$int2 = max($min, $max);
return mt_rand($int1, $int2);
}


if ($result >= $except) {
++$result;
Expand Down