Don't enable electron logging by default

FalkF · Aug 3, 2017 · b5bdf4a · b5bdf4a
1 parent 03b631a
commit b5bdf4a
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 15 deletions.
diff --git a/atom.sh b/atom.sh
@@ -31,6 +31,9 @@ while getopts ":wtfvh-:" opt; do
         foreground|benchmark|benchmark-test|test)
           EXPECT_OUTPUT=1
           ;;
+        enable-electron-logging)
+          export ELECTRON_ENABLE_LOGGING=1
+          ;;
       esac
       ;;
     w)
@@ -50,10 +53,6 @@ if [ $REDIRECT_STDERR ]; then
   exec 2> /dev/null
 fi
 
-if [ $EXPECT_OUTPUT ]; then
-  export ELECTRON_ENABLE_LOGGING=1
-fi
-
 if [ $OS == 'Mac' ]; then
   if [ -L "$0" ]; then
     SCRIPT="$(readlink "$0")"

diff --git a/resources/win/atom.cmd b/resources/win/atom.cmd
@@ -5,16 +5,17 @@ SET WAIT=
 SET PSARGS=%*
 
 FOR %%a IN (%*) DO (
-  IF /I "%%a"=="-f"               SET EXPECT_OUTPUT=YES
-  IF /I "%%a"=="--foreground"     SET EXPECT_OUTPUT=YES
-  IF /I "%%a"=="-h"               SET EXPECT_OUTPUT=YES
-  IF /I "%%a"=="--help"           SET EXPECT_OUTPUT=YES
-  IF /I "%%a"=="-t"               SET EXPECT_OUTPUT=YES
-  IF /I "%%a"=="--test"           SET EXPECT_OUTPUT=YES
-  IF /I "%%a"=="--benchmark"      SET EXPECT_OUTPUT=YES
-  IF /I "%%a"=="--benchmark-test" SET EXPECT_OUTPUT=YES
-  IF /I "%%a"=="-v"               SET EXPECT_OUTPUT=YES
-  IF /I "%%a"=="--version"        SET EXPECT_OUTPUT=YES
+  IF /I "%%a"=="-f"                         SET EXPECT_OUTPUT=YES
+  IF /I "%%a"=="--foreground"               SET EXPECT_OUTPUT=YES
+  IF /I "%%a"=="-h"                         SET EXPECT_OUTPUT=YES
+  IF /I "%%a"=="--help"                     SET EXPECT_OUTPUT=YES
+  IF /I "%%a"=="-t"                         SET EXPECT_OUTPUT=YES
+  IF /I "%%a"=="--test"                     SET EXPECT_OUTPUT=YES
+  IF /I "%%a"=="--benchmark"                SET EXPECT_OUTPUT=YES
+  IF /I "%%a"=="--benchmark-test"           SET EXPECT_OUTPUT=YES
+  IF /I "%%a"=="-v"                         SET EXPECT_OUTPUT=YES
+  IF /I "%%a"=="--version"                  SET EXPECT_OUTPUT=YES
+  IF /I "%%a"=="--enable-electron-logging"  SET ELECTRON_ENABLE_LOGGING=YES
   IF /I "%%a"=="-w"           (
     SET EXPECT_OUTPUT=YES
     SET WAIT=YES
@@ -26,7 +27,6 @@ FOR %%a IN (%*) DO (
 )
 
 IF "%EXPECT_OUTPUT%"=="YES" (
-  SET ELECTRON_ENABLE_LOGGING=YES
   IF "%WAIT%"=="YES" (
     powershell -noexit "Start-Process -FilePath \"%~dp0\..\..\atom.exe\" -ArgumentList \"--pid=$pid $env:PSARGS\" ; wait-event"
     exit 0