Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loot cyphers, scroll tweaks, and more #818

Closed
wants to merge 22 commits into from

Conversation

Robotgiggle
Copy link
Contributor

@Robotgiggle Robotgiggle commented Dec 13, 2024

  • Adds ancient cyphers, which can be found in a variety of loot tables and come preloaded with a random hex
    • Ancient cyphers look like normal cyphers but with tarnished copper and slightly faded amethyst, and work identically
    • Unlike normal cyphers, they display their stored hex in the tooltip, so they can serve as a tutorial for new players
    • You can also erase them and put in your own spells using Craft Cypher
  • Adds various new things related to Ancient Scrolls
    • You can now set the op_id without setting the pattern, which creates a scroll that loads your world's version of the pattern when ticked
    • There's now a creative mode tab containing all of the scrolls, including ones from addons, using the above feature to load the correct pattern when you grab one and put it in your inventory
    • The wandering trader now has a chance to sell one random scroll for 12 emeralds, which only reveals its stroke order when you buy it (finally, a way to get scrolls in skyblock!)
  • Adds two custom loot tables (hexcasting:random_scroll and hexcasting:random_cypher) that produce a guaranteed scroll or ancient cypher when generated
    • These aren't used anywhere in game, they're intended for use by packmakers or addon devs
  • Assorted new config options
    • Injection list and injection chance for ancient cyphers, just like how it works for lore fragments
    • List of preset hexes for ancient cyphers
    • Chance for wandering trader to sell a scroll
    • Toggle to enable comma-separated pattern lists

@gamma-delta
Copy link
Collaborator

Can you please split this into separate PRs?

  • Loot cyphers
  • Ancient scroll tweaks
  • The loot table stuff (open the PR containing the other PRs it depends on with the changes, then you can rebase if/when I merge the PRs it depends on)
  • Add the config changes to each PR as they're needed in that PR

This was referenced Jan 23, 2025
@Robotgiggle
Copy link
Contributor Author

Split into three new PRs (#837, #838, #839)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants