Oni Refactor #578
Open
Oni Refactor #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add ability for GunComponent to track their holders * Add new component to allow Players to modify gun attributes * Allow users of melee weapons to also modify their weapons damage * Allow user stamina damage modifiers * Allow users of tools to also modify tool attributes * Delete old Oni component and systems * Replace oni components * Set default max spread angle to 180 degrees * Change modifier to multiplier to better reflect the math * Add documentation. * Add NetworkedComponent to new components
github-actions
bot
added
Changes: C#
Removes unneeded trait system/component and fixes the traits with the new system. Also tweaks the new changes to work within our system since our stamina and melee damage systems are a bit different from DV.
Forzii
requested review from
Fansana,
Memeji,
FoxxoTrystan and
Mnemotechnician
as code owners
FoxxoTrystan
added
Undergoing Maintainer Discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ported Delta-V Oni refactor. This adds a Bonus Stamina Damage system, Tool modifier system, gun accuracy modifier system, and a way to modify melee damage easier. This will make creating additional species modifiers and traits that modify such things much easier! It also apparently makes the damage modifications show on the weapons when you hold them, which is neat.
DeltaV-Station/Delta-v#2805
DeltaV-Station/Delta-v#3032
TODO
Media
I guess maybe I could get a picture of the damage being different when Oni use it... I dunno, look at the Delta-V PR! They did the real work.
Changelog
🆑 BarryNorfolk and Forzii