Viewer now uses the standard Search dialog.

[MKadaner]

Summary

This is it: Viewer now uses the standard Search dialog. No changes in behavior are expected except for the two removed features (see Details).

References

• Unifying Viewer and Editor search. #584
• Viewer Search - First Char #614

Checklist

• I have followed the contributing guidelines.
• I have discussed this with project maintainers: See References above.
  
  If not checked, I accept that this work might be rejected in favor of another great big ineffable plan.
  

Details

Also removed:

• Opening Viewer Search dialog on typing the first character of the search pattern.
• Search dialog auto-focus feature. We discussed it somewhere, but I could not find the place.

What else did I forget to remove?

[MKadaner]

@rohitab, It would be great if you could test this change. The most interesting things to test are search for Hex in Viewer and saving / restoring dialog settings across searches and Viewer / Editor instances. In both cases no regressions are expected, but I did not attempt to address any known bugs / issues in these areas.

[rohitab]

Sure, I will test it out. Might not be able to get to it until tomorrow though, but I'll definitely try.

[MKadaner]

Thank you! No rush at all.

[MKadaner]

Thank you.

Changelog / version / rebased / squashed / ready.

[rohitab]

@MKadaner I just tested your changes and everything appears to be working fine. I did not find any issues with the search.

Since you removed Viewer.SearchEditFocus, do you think it should be removed from the macro testing code as well?

FarManager/plugins/luamacro/macrotest.lua

Lines 1006 to 1008 in 833c939

	"Viewer.SaveViewerWrapMode", "boolean",
	"Viewer.SearchEditFocus", "boolean",
	"Viewer.SearchRegexp", "boolean",

Right now, it won't make a difference since the code to test the configuration is commented out.

FarManager/plugins/luamacro/macrotest.lua

Line 1061 in 833c939

-- test_Far_GetConfig()

It's most likely commented since there are a lot of other left over settings that were never removed, and some settings where the type changed. Examples include Dialog.EditHistory, Interface.ShiftsKeyRules and Interface.ClearType. The test_Far_GetConfig function fails even in previous versions due to this.

[MKadaner]

Thank you for testing, @rohitab, and for discovering macrotest.lua. Frankly, I do not know what I should do with it. For now, I commented Viewer.SearchEditFocus out of the test. Tagging @alabuzhev to weigh in.

[alabuzhev]

macrotest.lua runs during CI.
If some parameters no longer exist please remove them from the test.

[MKadaner]

As Rohitab noted, Far config test was commented out six years ago (even though macrotest.lua is still executed):

FarManager/plugins/luamacro/macrotest.lua

Line 1061 in 833c939

-- test_Far_GetConfig()

I am not sure what is the value of this test, but let me fix it in a separate PR. It has nothing to do with Viewer Search. I created a bug to track this issue. You can assign it to me.

[MKadaner]

Thank you!