Connect 4 Visualization for Dynamic Board Sizes #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
threepwoody
reviewed
Dec 25, 2023
|
|
||
| self.screen.blit(board_img, (0, 0)) |
There was a problem hiding this comment.
The window resizing seems to work only for changed board width, not for changed board height (e.g. with a board height of >6 cells)
ffelten
approved these changes
Dec 27, 2023
| @@ -297,43 +297,52 @@ def render(self): # TODO adapt to different board sizes, low priority | |||
| if self.render_mode == "human": | |||
| pygame.display.set_caption("Connect Four") | |||
| self.screen = pygame.display.set_mode((screen_width, screen_height)) | |||
| elif self.render_mode == "rgb_array": | |||
| else: | |||
There was a problem hiding this comment.
I would have kept the elif
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented a dynamic board visualization using the single empty cell image from the original connect4 board. Needs fine tuning, some pixels are off causing tear, but the tiles seem to work fine.
Example:
