-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename SerializerProvider
as SerializationContext
#3043
Comments
/cc @JooHyukKim @pjfanning @k163377 I will be doing this major renaming now for 3.0/master. Apologies for short term disruption. This is part of my focusing again on making 3.0 actual reality. Will try to keep everyone informed. This work f.ex is part of JSTEP-6. |
SerializerProvider
as SerializationContext
(for 3.0)SerializerProvider
as SerializationContext
So far I have update almost all modules, including Kotlin but not Scala (but I think @pjfanning is already doing or has done that). One remaining failure is for |
Great work on the work itself and for focusing on 3.0 version! |
I am trying to go back to documentation, and updated https://github.com/FasterXML/jackson-future-ideas/wiki/JSTEP (plus JSTEPs referenced). But need to think of how to better combine different pieces so they would not be so disjoint. |
Something that should have been done during 1.x->2.0 major version upgrade but better late than never: due to historical reasons (serialization implemented before deserialization), context object naming is inconsistent. We have:
DeseralizationContext
for deserializationSerializerProvider
for serializationLatter may have made sense in 0.9.4 since the primary reason was access to child serializers (and this is still an importan use case); but conceptually it is a context object, and has expanded a lot in functionality.
So let's fix this naming discrepancy in 3.0.
(yes, this will result in lots of changes across the whole codebase)
EDIT: Related renaming:
JsonFormatVisitorWithSerializerProvider
->JsonFormatVisitorWithSerializationContext
The text was updated successfully, but these errors were encountered: