Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Json schema, mark dataclass fields with default_factory as non required #122

Merged
merged 1 commit into from
Jul 1, 2023
Merged

Json schema, mark dataclass fields with default_factory as non required #122

merged 1 commit into from
Jul 1, 2023

Conversation

mishamsk
Copy link
Contributor

This adds a minimal fix to prevent marking dataclass fields with default_factory as required in the schema.

I opted to not populate the default key in the schema similar to pydantic.

Resolves #114

@mishamsk mishamsk mentioned this pull request Jun 30, 2023
Closed
@Fatal1ty
Copy link
Owner

Fatal1ty commented Jul 1, 2023

Looks good, thank you!

@Fatal1ty Fatal1ty merged commit 062ee47 into Fatal1ty:master Jul 1, 2023
@mishamsk mishamsk deleted the json-schema-default-factory-support branch September 9, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSON Schema generator doesn't honor default_factory
2 participants
@mishamsk @Fatal1ty