Skip to content
This repository has been archived by the owner on Feb 21, 2024. It is now read-only.

Fix field value import: Use signed int and respect field minimum #919

Merged

Conversation

codysoyland
Copy link
Contributor

Overview

This allows negative numbers in field value imports and fixes the storage of the values when the field.Min is not 0.

Fixes #875

Pull request checklist

Code review checklist

This is the checklist that the reviewer will follow while reviewing your pull request. You do not need to do anything with this checklist, but be aware of what the reviewer will be looking for.

  • Ensure that any changes to external docs have been included in this pull request.
  • If the changes require that minor/major versions need to be updated, tag the PR appropriately.
  • Ensure the new code is properly commented and follows Idiomatic Go.
  • Check that tests have been written and that they cover the new functionality.
  • Run tests and ensure they pass.
  • Build and run the code, performing any applicable integration testing.

@codysoyland codysoyland merged commit aaee9b2 into FeatureBaseDB:master Oct 31, 2017
@codysoyland codysoyland deleted the 875-value-importer-bug branch October 31, 2017 19:37
seebs pushed a commit to seebs/pilosa that referenced this pull request Nov 19, 2020
 - avoid deadlock in txfactory_internal_test w Qcx
seebs pushed a commit to seebs/pilosa that referenced this pull request Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

value importer supports uint64, but field values are int64
2 participants