Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed prs toc #117

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Fixed prs toc #117

merged 1 commit into from
Nov 25, 2024

Conversation

jiayx
Copy link
Contributor

@jiayx jiayx commented Nov 25, 2024 •
edited
Loading

Now there is an additional layer of section in the body, causing the TOC to be inaccessible.

The current structure of OPS/toc.xhtml is like this:

<html xmlns="http://www.w3.org/1999/xhtml" xmlns:epub="http://www.idpf.org/2007/ops">
  <head>
    <title>Contents</title>
    <meta charset="utf-8">
    </meta>
  </head>
  <body>
    <section epub:type="toc">
      <nav epub:type="toc" id="toc">
        <ol>
          <li>
            <a href="cover.xhtml">Cover</a>
          </li>
          <li>
            <a href="page0003.xhtml">Title</a>
          </li>
          <li>
            <a href="page0004.xhtml">Contents</a>
          </li>
          <li>
            <a href="page0006.xhtml">Exam information</a>
          </li>
        </ol>
      </nav>
    </section>
  </body>
</html>

@jiayx
Copy link
Contributor Author

jiayx commented Nov 25, 2024

#64 It's related to this issue.

@FelixFrog
Copy link
Owner

Thank you so much for the pr! I'm merging it since it should still work for all the books

@FelixFrog FelixFrog merged commit bb6b026 into FelixFrog:master Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiayx @FelixFrog