Remove unused type arguments that cause allocations in Ferrite.cellnodes!() #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
approved these changes
Aug 19, 2021
Codecov Report
@@ Coverage Diff @@
## master #366 +/- ##
==========================================
+ Coverage 88.37% 88.70% +0.33%
==========================================
Files 20 20
Lines 2219 2285 +66
==========================================
+ Hits 1961 2027 +66
Misses 258 258
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems like a bug in julia? Feels weird, hopefully i am not benchmarking it wrong in some way 😅
@btime Ferrite.cellnodes!($nodes, $dh, $1)Before:
25.734 ns (1 allocation: 112 bytes)Now:
5.311 ns (0 allocations: 0 bytes)