feat: allow plugin users to create a ClientUI
#611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicdumz
changed the title
ClientUI
This would allow `age` library users to create the needed inputs to interact with the `plugin` module.
|
And now with 💯 passing tests, sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings,
I would like to suggest an alternative to #591 which will allow unblocking the consumer getsops/sops#1641. (I'm interested in plugin support in
sopsso I can try out FIDO2 keys inside of Nix viasops-nix).Instead of exposing all
ageinternals into a separate package (which I presume isn't the best from a maintenance PoV), I move functions which need to be shared betweenpluginandmaininto two new internal private modules.This lets me eventually expose
NewClientUI()for consumers.plugin.NewClientUI()Kudos to @brianmcgee for the original work.
@FiloSottile I'm happy to iterate on this code, let me know your constraints and I'll work with you.
HTH.