feat: CI-2184 set doppler autorotated keynames to ones accepted by si… #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gned-es-aws-fetch
juanSanchezAlcala
previously approved these changes
Apr 9, 2024
index.js
Outdated
| @@ -8,3 +8,8 @@ module.exports = { | |||
| mapping: require('./lib/mapping'), | |||
| msearch: require('./lib/msearch') | |||
| }; | |||
|
|
|||
| // doppler auto secret rotation requires a suffix of _ACCESS_KEY_ID, but signed-es-aws-fetch module does not have that in its list of accepted key names | |||
| if (process.env.ES_AWS_ACCESS_KEY_ID) { | |||
There was a problem hiding this comment.
Shouldn't this be at the beginning of the file?
There was a problem hiding this comment.
it won't affect them as they aren't required until signedFetch is called, but I'm moving to top as it is more typical to have the exports at the end
juanSanchezAlcala
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…gned-es-aws-fetch
doppler auto secret rotation requires a suffix of _ACCESS_KEY_ID, but signed-es-aws-fetch module does not have that in its list of accepted key names. This will get the doppler secret and set it to one of the approved signed-es-aws-fetch ones