FTDCS-151 - Use aws-sdk official package to sign requests to AWS #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanmanning
requested changes
Apr 26, 2022
lib/helpers/signed-aws-es-fetch.js
Outdated
Comment on lines
106
to
107
| async function signedFetch(url, opts, creds) { | ||
| creds = creds || {}; |
There was a problem hiding this comment.
nitpick: could this be a default param?
Suggested change
| async function signedFetch(url, opts, creds) { | |
| creds = creds || {}; | |
| async function signedFetch(url, opts, creds = {}) { |
rowanmanning
added a commit
that referenced
this pull request
Jul 12, 2022
This isn't working when we pull it into next-article and it hasn't been released yet. We don't understand this work enough to debug it and get it working and it's blocking our n-logger work from being merged and released. We'd like to revert everything. As it appeared in two different PRs, I decided to revert it commit by commit. The PRs are: - #86 - #93 The commit hashes I reverted in order are: - 826ca12 - b848fa4 - 5f6b1f5 - ffef3f8 - ce7e591 - 8af8c24 - 2c49ac9 - 0e5ec8f - 2ed8545 - 698302b - 6fd9cd5 - 6fd9cd5 - 2f229b8 - 48f79ce I'll be installing this branch in next-article before merging so that I can be sure that I didn't miss anything and that it's safe to install the latest version of n-es-client in our apps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.