-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fail more gracefully #25
Comments
In order to show a red cross and a "something’s gone wrong" modal I think we should replicate what we do with maintenance mode.
n-syndication/src/js/get-user-status.js Lines 25 to 30 in 22bb892
And then replicate this n-syndication/src/js/data-store.js Lines 42 to 57 in 22bb892
and n-syndication/src/js/modal-download.js Lines 171 to 176 in 22bb892
with a new custom message defined in |
Currently if we have a problem receiving user data from
next-syndication-api
we can't properly render the syndication icons because we don't know what they should be for the user.In some cases the old, smaller icons are rendered which link to http://ftsyndication.com, the now deprecated syndication platform(These were completely removed in #28 )We should probably render something like we do when syndication is in maintenance mode where they all are red crosses and say there's been an issue or something like that.
Example
The text was updated successfully, but these errors were encountered: