Refactor #28
Merged
Refactor #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🐿 v2.9.0
🐿 v2.9.0
🐿 v2.9.0
🐿 v2.9.0
🐿 v2.9.0
🐿 v2.9.0
🐿 v2.9.0
🐿 v2.9.0
🐿 v2.9.0
🐿 v2.9.0
🐿 v2.9.0
dapenguin
approved these changes
Jun 18, 2018
test/src/js/index.spec.js
Outdated
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| const { expect } = require('chai'); | |||
|
|
|||
| const underTest = require('../../../src/js/redux'); | |||
| const underTest = require('../../../src/js/index'); | |||
There was a problem hiding this comment.
Think you need to update the path in the describe() on line 7.
🐿 v2.9.0
🐿 v2.9.0
🐿 v2.9.0
🐿 v2.9.0
🐿 v2.9.0
dapenguin
approved these changes
Jun 19, 2018
test/src/js/index.spec.js
Outdated
|
|
||
| context('when syndication customer', () => { | ||
| it.skip('should return undefined if the user isn’t migrated', () => { }); | ||
| it.skip('should return initialise the republising navigation', () => { }); |
There was a problem hiding this comment.
Not sure I understand this one. IS the text correct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A reasonable refactor, but the individual commits/commit messages should help explain my process.
The aim of this is to reduce some of the complexity that n-syndication has. Trying to reduce the spread out config in favour of in-file config where appropriate (where stuff from config is only used in one place) to avoid file jumping when having to diagnose or search for code.