This repository has been archived by the owner on Nov 13, 2020. It is now read-only.
Upgrade s3o-middleware-utils to 2.0.0 #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes express cookie utilities from s3o-middleware-utils, and exports a factory function from authenticate which takes a sync public key getter and returns authenticateToken and validate methods. This change adds the cookie utils to this library and adjusts the calls to the middleware utils to keep the existing API intact. Note: s3o-middleware-utils now requires node.js >= 8. This is due to an ft-poller version update including native async/await calls.
lib/cookies.js
Outdated
| * Gets s3o username from request cookies | ||
| * | ||
| * @param {object} req Express request object | ||
| * @return {string} The S3O username if it exists |
There was a problem hiding this comment.
Suggested change
| * @return {string} The S3O username if it exists | |
| * @return {string|undefined} The S3O username if it exists |
lib/cookies.js
Outdated
| * Gets s3o username from request cookies | ||
| * | ||
| * @param {object} req Express request object | ||
| * @return {string} The S3O token if it exists |
There was a problem hiding this comment.
Suggested change
| * @return {string} The S3O token if it exists | |
| * @return {string|undefined} The S3O token if it exists |
JakeChampion
approved these changes
Mar 26, 2019
JakeChampion
approved these changes
Mar 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes express cookie utilities from s3o-middleware-utils, and exports a factory function from authenticate which takes a sync public key getter and returns authenticateToken and validate methods. This was to allow
s3o-lambdato consume the same library without immediately polling for public key changes (Financial-Times/s3o-middleware-utils#8).This change adds the cookie utils to this library and adjusts the calls to the middleware utils to keep the existing API intact. I'd have liked to expose this middleware with a factory function as an entry point as well:
however I don't personally have the appetite to manage that upgrade process.
Note: s3o-middleware-utils now requires node.js >= 8. This is due to an ft-poller version update including native async/await calls. This should result in this being a major release. node.js 6 supports ends at the end of next month (April 2019) so I believe this is a reasonable breaking change at this point.
This would not require consumers to update immediately.