Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply the changes of lbm-sdk v0.4.0-rc0 #23

Merged
merged 8 commits into from
May 16, 2022
Merged

apply the changes of lbm-sdk v0.4.0-rc0 #23

merged 8 commits into from
May 16, 2022

Conversation

zemyblue
Copy link
Member

Description

apply the changes of lbm-sdk v0.4.0-rc0

  • apply the change the value type of wasm function
  • apply the protobuf changes (lbmjs-types v0.4.0-rc1)

* apply the change the value type of wasm function
* apply the protobuf changes (lbmjs-types v0.4.0-rc1)

Signed-off-by: zemyblue <[email protected]>
@zemyblue zemyblue marked this pull request as draft May 12, 2022 13:28
@zemyblue zemyblue self-assigned this May 12, 2022
@zemyblue zemyblue marked this pull request as ready for review May 15, 2022 12:28
@zemyblue zemyblue requested review from 0Tech, dudong2 and loin3 May 15, 2022 12:29
Copy link

@dudong2 dudong2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

);
assertIsDeliverTxSuccess(grantResult);

await sleep(75);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is await sleep(75) used for?

@loin3 loin3 self-requested a review May 16, 2022 05:12
@zemyblue zemyblue merged commit d3a484f into main May 16, 2022
@zemyblue zemyblue deleted the apply_lbm_v0.4.0 branch June 9, 2022 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants