Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci fix not to publish on release #91

Merged
merged 2 commits into from
May 2, 2023
Merged

ci fix not to publish on release #91

merged 2 commits into from
May 2, 2023

Conversation

loin3
Copy link
Contributor

@loin3 loin3 commented May 2, 2023 •
edited
Loading

Description

Motivation and context

Currently auto publish workflow runs on every tag push and release.
This makes error because same version will be publish to NPM twice.
I fix ci only run on tag push and does not run on release.

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I have added a relevant changelog to CHANGELOG.md.
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

@loin3 loin3 changed the title ci fix not to pusblish on release ci fix not to publish on release May 2, 2023
@loin3 loin3 merged commit b399869 into main May 2, 2023
@loin3 loin3 deleted the ci/not_publish_on_rel branch May 2, 2023 09:35
zemyblue added a commit that referenced this pull request May 2, 2023
@zemyblue
Merge commit 'b399869454d3a50758e1bf8d168ea560b71a287c' into feat/rel…
47b3dc3 
…_v0.8.0

* commit 'b399869454d3a50758e1bf8d168ea560b71a287c':
  ci fix not to publish on release (#91)
  Change lbmjs-types to finschia-proto (#90)
@zemyblue zemyblue mentioned this pull request May 2, 2023
Merged
@loin3 loin3 self-assigned this May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeseung-bae jaeseung-bae jaeseung-bae approved these changes

@zemyblue zemyblue zemyblue approved these changes

@0Tech 0Tech Awaiting requested review from 0Tech

@dudong2 dudong2 Awaiting requested review from dudong2

@tkxkd0159 tkxkd0159 Awaiting requested review from tkxkd0159

Assignees

@loin3 loin3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loin3 @zemyblue @jaeseung-bae