feat(wasm): porting our modifications after 0.12.0-0.1.0 #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brew0722
force-pushed
the
brew0722/v2/feat/port-after-0.1.0
branch
from
44f2155 to
aadb256
Compare
brew0722
pushed a commit
that referenced
this pull request
Apr 26, 2021
Use alpine to build wasmd docker image
brew0722
force-pushed
the
brew0722/v2/feat/port-after-0.1.0
branch
4 times, most recently
from
e60306f to
1622800
Compare
Codecov Report
@@ Coverage Diff @@
## v2/develop #139 +/- ##
==============================================
+ Coverage 54.99% 55.05% +0.06%
==============================================
Files 812 811 -1
Lines 51487 51492 +5
==============================================
+ Hits 28317 28351 +34
+ Misses 20211 20197 -14
+ Partials 2959 2944 -15
|
The original is the PR #85. cherry-pick from v1/develop by Jiyong Ha<[email protected]>
The original is the PR #86. with excessive gas consumption issue needs further modification. cherry-pick from v1/develop by Jiyong Ha<[email protected]>
Limit values are greatly eased due to the known issue of gas consumption.
brew0722
force-pushed
the
brew0722/v2/feat/port-after-0.1.0
branch
from
683f26c to
16f15b1
Compare
This was
linked to
issues
Apr 27, 2021
brew0722
changed the title
whylee259
suggested changes
Apr 28, 2021
whylee259
approved these changes
Apr 28, 2021
loloicci
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Since the initial code of v2/x/wasm was set to 0.12.0-0.1.0, the migration PR(#131) is only merged up to 0.1.0.
Modifications after 0.1.0 port from this PR. And change the commit author to the original PR author.
feat: implement pagination for x/wasm query #85
cosmos pagination included by stargate migration.
So I just add rest pagination part of all.
feat: Make hardcoded params to gov params #86
I add everything except MaxGas gov params.
Please note that the known issue of excessive gas consumption is included. (Increased gas when using paramspace for hardcode params to gov params #134)
And MemoryLimit should also be added after as gov params. (Change hardcoded memory limit to gov param #135)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes