Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update fastcache metrics with go routine #206

Merged
merged 4 commits into from
May 26, 2021

Conversation

egonspace
Copy link

Description

Execution time of fastcache.UpdateStats() can increase linearly as cache entries grows.
So we need to update the metrics with a separate go route.

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@egonspace egonspace self-assigned this May 26, 2021
@egonspace egonspace added this to the performance improvement milestone May 26, 2021
@egonspace egonspace requested review from wetcod and iproudhon May 26, 2021 01:41
@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #206 (856d4b4) into v2/develop (88ab1bd) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           v2/develop     #206      +/-   ##
==============================================
- Coverage       53.49%   53.48%   -0.02%     
==============================================
  Files             653      652       -1     
  Lines           47376    47341      -35     
==============================================
- Hits            25343    25318      -25     
+ Misses          19178    19170       -8     
+ Partials         2855     2853       -2     
Impacted Files Coverage Δ
baseapp/baseapp.go 77.94% <ø> (+0.85%) ⬆️
simapp/app.go 83.96% <ø> (+0.16%) ⬆️
store/cache/cache.go 88.88% <ø> (+0.65%) ⬆️
store/iavl/store.go 66.36% <ø> (+0.29%) ⬆️
store/rootmulti/store.go 65.25% <ø> (-0.72%) ⬇️
store/types/gas.go 75.00% <ø> (+1.82%) ⬆️
store/types/store.go 58.82% <ø> (-1.18%) ⬇️
types/context.go 96.15% <ø> (+1.21%) ⬆️
types/store.go 56.25% <ø> (-8.75%) ⬇️
x/params/keeper/keeper.go 72.22% <ø> (-1.47%) ⬇️
... and 11 more

Copy link
Contributor

@wetcod wetcod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@egonspace egonspace merged commit 4bf9d52 into v2/develop May 26, 2021
@egonspace egonspace deleted the egon/v2/fix/remove_fastcache_updatestats branch May 26, 2021 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants