-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix message representation for signing #513
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #513 +/- ##
==========================================
+ Coverage 56.75% 56.80% +0.04%
==========================================
Files 777 777
Lines 83389 83369 -20
==========================================
+ Hits 47331 47355 +24
+ Misses 33004 32959 -45
- Partials 3054 3055 +1
|
dudong2
reviewed
Apr 28, 2022
loloicci
approved these changes
Apr 28, 2022
dudong2
approved these changes
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR change the msg incomming and outgoing data to contract.
It allows to input and output the actual json object to msg. This fix is based on CosmWasm/wasmd#658
Additionally, init_msg of MsgStoreCodeAndInstantiateContract is also changed to msg.
Motivation and context
The existing
json.RawMessage
is inconvenient because the part that needs to be used after converting json requires conversion when generating the actual tx.How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml