Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom abci interface to extended Tendermint abci interface #689

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

ulbqb
Copy link
Member

@ulbqb ulbqb commented Aug 7, 2023

Description

Closes: #688

This PR has changes for compatibility improvement using Tendermint abci interface.

  • 474e6aa: Remove Entropy from RequestBeginBlock
  • 83f6119: Use Tendermint's ResponseCheckTx

@ulbqb ulbqb changed the title Remove entropy Remove entropy from BeginBlock Aug 7, 2023
@ulbqb ulbqb self-assigned this Aug 7, 2023
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

❗ No coverage uploaded for pull request base (ramus@d971aa4). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff            @@
##             ramus     #689   +/-   ##
========================================
  Coverage         ?   66.54%           
========================================
  Files            ?      282           
  Lines            ?    37854           
  Branches         ?        0           
========================================
  Hits             ?    25189           
  Misses           ?    10860           
  Partials         ?     1805           

@ulbqb ulbqb marked this pull request as ready for review August 8, 2023 02:35
@ulbqb ulbqb requested review from torao and tnasu as code owners August 8, 2023 02:35
@ulbqb ulbqb changed the base branch from main to ramus August 8, 2023 03:08
@ulbqb ulbqb changed the title Remove entropy from BeginBlock Make abci interface extended Tendermint abci interface Aug 9, 2023
@ulbqb ulbqb changed the title Make abci interface extended Tendermint abci interface Custom abci interface to extended Tendermint abci interface Aug 9, 2023
@ulbqb ulbqb added the C: enhancement Classification: New feature or its request, or improvement in maintainability of code label Aug 9, 2023
@ulbqb ulbqb merged commit 5836604 into Finschia:ramus Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: enhancement Classification: New feature or its request, or improvement in maintainability of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom abci interface to extended Tendermint abci interface
3 participants