-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support multiple allowIPs for a remote connection from one of KMS servers #707
Conversation
f6c01ac
to
190088f
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #707 +/- ##
==========================================
+ Coverage 66.54% 66.58% +0.04%
==========================================
Files 285 285
Lines 37915 37919 +4
==========================================
+ Hits 25229 25249 +20
+ Misses 10878 10867 -11
+ Partials 1808 1803 -5
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a valid address checking?
Is it possible using url not ip? if then, are there any security issues?
There is no validation logic for valid address.
For now, it's not possible because when accepting a connection what I can receive is |
Then, what happen if I write |
None of the connections will be accepted because no address match to |
Co-authored-by: Torao Takami <[email protected]>
Description