Fix: LF line endings aren't supported. #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always convert line endings to CRLF on checkout for .pal files, because they must keep CRLF endings, even on OSX or Linux, otherwise gbagfx will complain that 'LF line endings aren't supported.'.
|
2 solutions to fix this problem:
I choose the first one to keep consistent with pret. |
laqieer
added a commit
to laqieer/fireemblem8u
that referenced
this pull request
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always convert line endings to CRLF on checkout for
.palfiles, because they must keep CRLF endings, even on OSX or Linux, otherwise gbagfx will complain thatLF line endings aren't supported..fireemblem8u/tools/gbagfx/jasc_pal.c
Line 49 in c90d890