Handwritten asm files and small bugfixes in building #661

laqieer · 2024-08-17T07:55:41Z

Move handwritten assembly source files from asm/ to src/, which needn't decomp because they are not written by C at first, not to confuse the calculation of decomp progress
- crt0.s: C runtime (CRT), ROM header splitted to rom_header.s
- m4a_1.s: MP2k engine
- libagbsyscall.s: BIOS syscall library
Bugfixes in Makefile
- Issue: leftover object files are never cleaned
  - Reason: corresponding source files are removed or renamed
  - Solution: search and remove leftovers in the last step of make clean
- Issue: unnecessary step to recompress texts in make clean or make tag
  - Reason: .d files (automatically created dependency files) are included by the Makefile, they must exist for any target to be made, including clean and tag, and .dep/src/msg_data.d depends on src/msg_data.c depends on msg_list.txt
  - Solution: not include those .d files in make clean and make tag by comparing with MAKECMDGOALS

Fix warnings like: ``` Makefile:231: warning: overriding commands for target `src/agb_sram.o' Makefile:189: warning: ignoring old commands for target `src/agb_sram.o' ```

…tag` - reference: https://stackoverflow.com/questions/12857020/gnu-make-clean-target-depends-on-includes - doc: https://www.gnu.org/software/make/manual/html_node/Goals.html

laqieer added 5 commits August 17, 2024 14:20

Move hand-written assembly source files from asm/ to src/

fd4f705

Remove all object files when running make clean

d989c2b

Move text recipes above

210d653

Fix handwritten assembly source files in Makefile

db1e85b

Fix warnings like: ``` Makefile:231: warning: overriding commands for target `src/agb_sram.o' Makefile:189: warning: ignoring old commands for target `src/agb_sram.o' ```

Fix meaningless texts compression when running make clean or `make …

19c30b3

…tag` - reference: https://stackoverflow.com/questions/12857020/gnu-make-clean-target-depends-on-includes - doc: https://www.gnu.org/software/make/manual/html_node/Goals.html

RevoSucks merged commit b7b95d8 into FireEmblemUniverse:master Aug 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handwritten asm files and small bugfixes in building #661

Handwritten asm files and small bugfixes in building #661

laqieer commented Aug 17, 2024 •

edited

Loading

Handwritten asm files and small bugfixes in building #661

Handwritten asm files and small bugfixes in building #661

Conversation

laqieer commented Aug 17, 2024 • edited Loading

laqieer commented Aug 17, 2024 •

edited

Loading