Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use resolveRegistration to lookup firebase auth providers. #498

Merged

Conversation

m-basov
Copy link
Contributor

@m-basov m-basov commented Apr 5, 2017

Description

When using emberfire with Ember 2.12 authentication is not working.

Before code used to find provider class utilized method lookup. It tries to find firebase-auth-provider:<provider> factory but nothing was found.

const ProviderClass = getOwner(this).lookup(`firebase-auth-provider:${providerId}`);

Instead we need to use resolveRegistration to find auth provider.

const ProviderClass = getOwner(this).resolveRegistration(`firebase-auth-provider:${providerId}`);

This PR should fix Issue #493.

@m-basov
Copy link
Contributor Author

m-basov commented Apr 5, 2017

Build for ember-data 2.10 timed out, restart it please. There are should not be errors.

@jamesdaniels jamesdaniels merged commit 85e8f0f into FirebaseExtended:master Apr 5, 2017
@jamesdaniels
Copy link
Contributor

Thanks for the contribution!

@itwasmattgregg
Copy link

I'm still getting this issue @kolybasov trying to run a basic session open. ember2.12.1 emberfire2.0.6

this.get('session').open('firebase', { provider: provider});

@m-basov
Copy link
Contributor Author

m-basov commented Apr 8, 2017

@itwasmattgregg this fix is not included into release yet. Ensure you have master branch installed.

npm install --save-dev 'github:firebase/emberfire#master'

or with yarn

yarn add 'github:firebase/emberfire#master'

@marekcieslar
Copy link

marekcieslar commented Apr 8, 2017

Working! :) Thanks a lot!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants