Made changes to allow compilation with closure compiler #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e111077
requested changes
Apr 21, 2017
firebase-database-behavior.html
Outdated
| */ | ||
| path: { | ||
| type: String, | ||
| observer: '__pathChanged', | ||
| value: null | ||
| observer: '__pathChanged' |
There was a problem hiding this comment.
Why was the default value removed? This is a breaking change, yet it should fit in the same spec. Also will {String} work since it's nullable unlike {string}
firebase-document.html
Outdated
| @@ -50,14 +50,14 @@ | |||
| }, | |||
|
|
|||
| /** | |||
| * @override | |||
| * Getter for the new property | |||
There was a problem hiding this comment.
this can be removed as the syntax explains it
firebase-document.html
Outdated
| */ | ||
| get isNew() { | ||
| return this.disabled || !this.__pathReady(this.path); | ||
| }, | ||
|
|
||
| /** | ||
| * @override | ||
| * Getter for the zero value. |
firebase-document.html
Outdated
| */ | ||
| saveValue: function(parentPath, key) { | ||
| return new Promise(function(resolve, reject) { | ||
| var path; | ||
| var path = ''; |
There was a problem hiding this comment.
suggest null over '' since it was possible for this.path = undefined before. null is closer to undefined over ''
firebase-document.html
Outdated
| @@ -103,15 +103,15 @@ | |||
| }, | |||
|
|
|||
| /** | |||
| * @override | |||
| * | |||
firebase-messaging.html
Outdated
| @@ -249,7 +255,7 @@ | |||
|
|
|||
| _bootstrapApp: function(app, customSw) { | |||
| if (app && !customSw) { | |||
| this.activate(); | |||
| this.activate(null); | |||
There was a problem hiding this comment.
this exposes a problem that the user will no longer be able to simply call this.activate in closure. Please change the @param in activate to have @param{ServiceWorkerRegistration=}
firebase-query.html
Outdated
| @@ -180,7 +180,7 @@ | |||
| }, | |||
|
|
|||
| /** | |||
| * @override | |||
| * | |||
firebase-query.html
Outdated
| @@ -200,7 +200,7 @@ | |||
| }, | |||
|
|
|||
| /** | |||
| * @override | |||
| * | |||
firebase-query.html
Outdated
| @@ -221,7 +221,7 @@ | |||
| }, | |||
|
|
|||
| /** | |||
| * @override | |||
| * | |||
firebase-query.html
Outdated
| @@ -277,7 +277,7 @@ | |||
| }, | |||
|
|
|||
| /** | |||
| * `@override` | |||
| * | |||
e111077
approved these changes
Apr 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.