This repository was archived by the owner on Jul 8, 2024. It is now read-only.
Fix duplicate evaluation of scalar expressions #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @JoostSchipperheijn. We will investigate this. I've already run the FhirPath tests for R4, and they succeeded as well with your solution. |
ewoutkramer
added
bug
ewoutkramer
approved these changes
Dec 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Firely,
I noticed that scalar expressions are evaluated twice in the current implementation.
This has a performance penalty and can cause problems for custom functions that maintain state.
I fixed the problem and added a unit test to validate it.
The take(2) call composes the minimal number of objects
required to determine whether the evaluation has 0, 1 or more results.
Can you have a look?
Thanks -- Joost Schipperheijn