This repository was archived by the owner on Jul 8, 2024. It is now read-only.
Add package client to fhir package resolver #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…true_not_false_or_empty' into feature/1987-add-package-client-to-resolver
marcovisserFurore
suggested changes
Mar 1, 2022
| string? cache_folder = localCache ? scopePath : null; | ||
| var cache = new DiskPackageCache(cache_folder); | ||
| var project = new FolderProject(scopePath); | ||
| #pragma warning disable CS8604 // Possible null reference argument. |
There was a problem hiding this comment.
This warning can be removed, because the constructor of PackageContext can handle null for the server.
There was a problem hiding this comment.
Only in a newer version of the NuGet package, which hasn't been published, since it's still waiting for review.
| var scopePath = getScopePath(); | ||
| var scope = await createContext(scopePath, client: null); | ||
|
|
||
| foreach (var path in paths) |
There was a problem hiding this comment.
This foreach would better fit in the createContext I think.
marcovisserFurore
approved these changes
Mar 1, 2022
| throw new FileNotFoundException($"Could not resolve all dependencies. Missing: {missingDeps}."); | ||
| } | ||
| } | ||
| //install packages from local machine | ||
| if (filePaths is not null && filePaths.Any()) |
There was a problem hiding this comment.
To eliminate the if clause, you can also do this:
foreach (var path in filePaths ?? Enumerable.Empty<string>())
marcovisserFurore
deleted the
feature/1987-add-package-client-to-resolver
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1987