Validate input parameters in terminology service #1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d-check-parameters # Conflicts: # src/Hl7.Fhir.Specification.Tests/Source/TerminologyTests.cs # src/Hl7.Fhir.Specification/Specification/Terminology/ExternalTerminologyService.cs # src/Hl7.Fhir.Specification/Specification/Terminology/ValidateCodeParameters.cs
mmsmits
requested review from
ewoutkramer
and removed request for
marcovisserFurore
…urn false outcomes instead of throwing exceptions.
…erminologyService
…d-check-parameters
ewoutkramer
previously approved these changes
Apr 16, 2021
src/Hl7.Fhir.Specification/Specification/Terminology/ExternalTerminologyService.cs
Outdated
Show resolved
Hide resolved
src/Hl7.Fhir.Specification/Specification/Terminology/ExternalTerminologyService.cs
Outdated
Show resolved
Hide resolved
…ain parameters checks
…e boolean instead of throwing an exception
ewoutkramer
previously approved these changes
Apr 16, 2021
ewoutkramer
requested changes
Apr 18, 2021
src/Hl7.Fhir.Specification.Tests/Validation/BindingValidationTests.cs
Outdated
Show resolved
Hide resolved
…ocalterminologyservice
…lient error is detected
…erminologyservice-should-check-parameters
…erminologyservice-should-check-parameters
…d-check-parameters
ewoutkramer
requested changes
May 3, 2021
| @@ -25,16 +25,30 @@ public ExternalTerminologyService(BaseFhirClient client) | |||
|
|
|||
| public BaseFhirClient Endpoint { get; set; } | |||
|
|
|||
| /// <summary> | |||
There was a problem hiding this comment.
This method is an implementation of the corresponding method on ITerminologyService. Move this comment there, and replace the comment here with <inheritdoc />, otherwise, you'll find yourself having to repeat this comment on every implementation.
| @@ -161,6 +183,14 @@ private Parameters falseOutcome(string message) | |||
| return result; | |||
| } | |||
|
|
|||
| private Parameters warningOutcome(string message) | |||
There was a problem hiding this comment.
ha were too fast, already gone
|
|
||
| //ValueSetExpander keeps throwing TerminologyService Exceptions to not change the public interface. | ||
| #pragma warning disable 0618 | ||
|
|
||
| public ValueSetExpanderSettings Settings { get; } | ||
|
|
||
| public ValueSetExpander(ValueSetExpanderSettings settings) |
There was a problem hiding this comment.
Add a #pragma warning restore below the section to re-enable 0618.
| { | ||
| string message = (cc?.Coding == null || cc.Coding.Count == 1) | ||
| ? $"Terminology service failed while validating code '{code ?? coding?.Code ?? cc?.Coding[0]?.Code}' (system '{system ?? coding?.System ?? cc?.Coding[0]?.System}'): {tse.Message}" | ||
| : $"Terminology service failed while validating the codes: {tse.Message}"; | ||
|
|
||
| return Issue.TERMINOLOGY_SERVICE_FAILED | ||
| return Issue.TERMINOLOGY_OUTPUT_WARNING |
There was a problem hiding this comment.
The text in the error messages says "terminology service failed", but the Issue is now a TERMINOLOGY_OUTPUT_WARNING. Since TERMINOLOGY_SERVICE_FAILED was already an issue of level Warning (which is what we want to achieve), I'd say we keep on using the TERM_SERVICE_FAILED issue - it did return a 4xx after all.
ewoutkramer
approved these changes
May 3, 2021
…d-check-parameters
marcovisserFurore
deleted the
bugfix/1651-terminologyservice-should-check-parameters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #1651