Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of FHIR R5 release version 4.6.0 #1737

Merged
merged 14 commits into from
May 27, 2021

Conversation

marcovisserFurore
Copy link
Member

@marcovisserFurore marcovisserFurore commented May 25, 2021

Description

Implementing the FHIR Release #5: Draft Ballot, version 4.6.0. See http://hl7.org/fhir/2021May/

Known problems

  • FHIR-32785 DeviceDefinition has components which should have explicitNames.
  • Profiles-resources.xml:
    • FHIR-32780 References to valueSets has a double version, which is not correct. For example:
      <valueSet value="http://hl7.org/fhir/ValueSet/administrative-gender|4.6.0|4.6.0" />
    • FHIR-32781 The type of Citation.differential[0].summary and Citation.snapshot[0].summary is ContactDetail but should be BackboneElement
    • FHIR-32779 Several structuredefintions contain bindings with an unknown extension: http://hl7.org/fhir/build/StructureDefinition/definition
  • Resource SubscriptionTopic
    • FHIR-32783 resourceTrigger: contains an element resourceType, which is conflicting with the property resourceType which informs the parser which resource type this is
  • Example.json.zip FHIR-32784:
    • conceptmaps.json: entry[14] contains a conceptmap with a single identifier (no array)
    • conceptmaps.json: entry[15] contains a conceptmap with a single identifier (no array)
    • All examples which contain a questionnaire (files end with -questionnaire.json) are invalid, because the type of a Questionnaire.Item cannot be choice. This should be coding.
  • Fhir-single.xsd:
    • FHIR-32778 Missing definition for ResourceType and ResourceType-list
  • FHIR-32782 Package hl7.fhir.r5.core-4.6.0 does not contain all the searchparameters anymore.

FirelyTeam Checklist

  • Update the title of the PR to be succinct and less than 50 characters
  • Mark the PR with the label breaking change when this PR introduces breaking changes

@marcovisserFurore marcovisserFurore marked this pull request as ready for review May 26, 2021 13:04
ewoutkramer
ewoutkramer previously approved these changes May 26, 2021
Copy link
Member

@ewoutkramer ewoutkramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how we will know how to re-enable the unit-test we now have set to "ignore"?

@marcovisserFurore
Copy link
Member Author

I wonder how we will know how to re-enable the unit-test we now have set to "ignore"?

You are right. I am sure we will forget about this ;) So I enabled the unittest again and changed the code a bit.

@marcovisserFurore marcovisserFurore merged commit b60c4d1 into develop-r5 May 27, 2021
@marcovisserFurore marcovisserFurore deleted the feature/New-R5-version460 branch May 27, 2021 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants