Snapshot generator: corrected cardinality of element with a derived type #1826
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When you were using a profile with an element that has again a profiled type. then the snapshot generator used the cardinality of that profiled type, and not the cardinality of the element. So
For example when you profile the element
Observation.code
and you use a derived type for this element, for exampleCodeableConceptProfile
, then the cardinality ofCodeableConceptProfile
was used for the elementObservation.code
. In this case the minimum cardinality ofObservation.code
went from1
to0
, which is incorrect. This has been solved in this PR.Related issues
Fixes #1824
Testing
Unit test
SnapshotGeneratorTest2.CheckCardinalityOfProfiledType()
FirelyTeam Checklist