Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot generator: corrected cardinality of element with a derived type #1826

Merged
merged 2 commits into from
Aug 5, 2021

Conversation

marcovisserFurore
Copy link
Member

Description

When you were using a profile with an element that has again a profiled type. then the snapshot generator used the cardinality of that profiled type, and not the cardinality of the element. So

For example when you profile the element Observation.code and you use a derived type for this element, for example CodeableConceptProfile, then the cardinality of CodeableConceptProfile was used for the element Observation.code. In this case the minimum cardinality of Observation.code went from 1 to 0, which is incorrect. This has been solved in this PR.

Related issues

Fixes #1824

Testing

Unit test SnapshotGeneratorTest2.CheckCardinalityOfProfiledType()

FirelyTeam Checklist

  • Update the title of the PR to be succinct and less than 50 characters
  • Mark the PR with the label breaking change when this PR introduces breaking changes

@marcovisserFurore marcovisserFurore merged commit 9131e6e into develop-stu3 Aug 5, 2021
@marcovisserFurore marcovisserFurore deleted the feature/1824-wrong-cardinality branch August 5, 2021 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong element cardinality
2 participants