Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create new constructors for Json and Xml Poco(de)Serializers #2370

Merged
merged 6 commits into from
Jan 25, 2023
Merged

Create new constructors for Json and Xml Poco(de)Serializers #2370

merged 6 commits into from
Jan 25, 2023

Conversation

mmsmits
Copy link
Member

@mmsmits mmsmits commented Jan 24, 2023 •
edited
Loading

fixes #2353

@mmsmits mmsmits requested a review from ewoutkramer January 24, 2023 13:53
@mmsmits mmsmits added the breaking change This issue/commit causes a breaking change, and requires a major version upgrade label Jan 24, 2023
@mmsmits mmsmits changed the title Create new initializers of XmlPoco(de)Serializers Create new constructors for XmlPoco(de)Serializers Jan 24, 2023
@mmsmits mmsmits removed the breaking change This issue/commit causes a breaking change, and requires a major version upgrade label Jan 25, 2023
@mmsmits mmsmits changed the title Create new constructors for XmlPoco(de)Serializers Create new constructors for Json and Xml Poco(de)Serializers Jan 25, 2023
marcovisserFurore
marcovisserFurore requested changes Jan 25, 2023
View reviewed changes
Copy link
Member

@marcovisserFurore marcovisserFurore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments

src/Hl7.Fhir.Shims.STU3AndUp/Serialization/FhirJsonPocoDeserializer.cs Outdated
@@ -0,0 +1,45 @@
using Hl7.Fhir.Introspection;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you enable nullable here?

@mmsmits mmsmits merged commit 99b3410 into release/5.0.0 Jan 25, 2023
@mmsmits mmsmits deleted the feature/improved-initialization-xml-serializers branch January 25, 2023 20:50
@ewoutkramer ewoutkramer mentioned this pull request Jul 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewoutkramer ewoutkramer ewoutkramer approved these changes

@marcovisserFurore marcovisserFurore Awaiting requested review from marcovisserFurore

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmsmits @ewoutkramer @marcovisserFurore