Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2454 Handle the parsing of json arrays to handle duplicate array values #2455

Merged
merged 7 commits into from
May 26, 2023

Conversation

brianpos
Copy link
Collaborator

(both orders and extension/value)

Description

Update to json parser to handle the case.

Related issues

Fixes issue #2454

Testing

Unit test included to verify functionality

FirelyTeam Checklist

  • Update the title of the PR to be succinct and less than 50 characters
  • Mark the PR with the label breaking change when this PR introduces breaking changes

@brianpos brianpos marked this pull request as draft May 11, 2023 21:46
@brianpos brianpos marked this pull request as ready for review May 17, 2023 20:46
Base automatically changed from feature/BP-2414-Parsing-Enhancements to develop May 22, 2023 08:29
Copy link
Member

@ewoutkramer ewoutkramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things...

return 0;
}

public void ParsedPropertyValue(string memberName, int count)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SetPropertyIndex?


public void Schedule(string key, Action validation)
public int ParsingPropertyValue(string memberName)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GetPropertyIndex?

@mmsmits
Copy link
Member

mmsmits commented May 25, 2023

fixes #2465

@mmsmits mmsmits enabled auto-merge May 26, 2023 11:59
@mmsmits mmsmits merged commit f8803ad into develop May 26, 2023
@mmsmits mmsmits deleted the feature/BP-2454-JsonDupArray branch May 26, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants