Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MimeType Terminology Service #2470

Merged
merged 17 commits into from
May 26, 2023

Conversation

mmsmits
Copy link
Member

@mmsmits mmsmits commented May 23, 2023

Fixes #1055

Todo in another PR: refactor some duplicate code with local terminology service

@mmsmits mmsmits requested a review from ewoutkramer May 23, 2023 13:48
Copy link
Member

@ewoutkramer ewoutkramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just very small things. In general: make the error messages end with a period ;-)

@mmsmits mmsmits requested a review from ewoutkramer May 26, 2023 09:58
@mmsmits mmsmits enabled auto-merge May 26, 2023 09:58
@mmsmits mmsmits merged commit ab28a7c into develop May 26, 2023
@mmsmits mmsmits deleted the feature/1055-mime-type-terminology-service branch May 26, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terminology service raises warningi for mimetypes
3 participants