Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VONK-5300 Accessing the Definition when visiting all descendants of a ITypedElement #2594

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

louisledev
Copy link
Contributor

@louisledev louisledev commented Sep 18, 2023

Description

Add an access to the Definition property when visiting all descendants of a ITypedElement in order to detect element with an invalid definition .
Background for this PR: In Vonk, for the patch operation, we create a PartToElementAdapter (see https://github.com/FirelyTeam/Vonk/blob/0b352a37b8d717b4c590622dc5d89347670e5c54/src/Vonk.Core/ElementModel/FhirPatchedElement.cs#L176) with the field to patch. In case of a non-existing field for the resource type to be patched, when getting the definition of the element, we get an exception. So, as part of the prevalidation for the patch operation, we would like to check that both the value but also the definition of all the PartToElementAdapter are valid.
see PR fixing the issue locally in VONK: https://github.com/FirelyTeam/Vonk/pull/1300

Related issues

VONK-5300

Testing

Tested using Firely Server. See https://github.com/FirelyTeam/Vonk/pull/1300

FirelyTeam Checklist

  • Update the title of the PR to be succinct and less than 50 characters
  • Mark the PR with the label breaking change when this PR introduces breaking changes

@marcovisserFurore
Copy link
Member

We think this change will have a big impact on the performance for our existing and future users. We understand that this issue is a problem for the Firely Server, but maybe we can come up with a different solution with less impact. See the added issue here.

@louisledev louisledev deleted the fix/add_check_on_definition_when_visiting branch December 19, 2023 16:39
@mmsmits mmsmits restored the fix/add_check_on_definition_when_visiting branch March 21, 2024 09:39
@mmsmits mmsmits reopened this Mar 21, 2024
@mmsmits mmsmits marked this pull request as ready for review March 21, 2024 09:39
@mmsmits mmsmits requested review from mmsmits and removed request for marcovisserFurore March 21, 2024 09:39
@mmsmits mmsmits merged commit 3e54cec into develop Mar 21, 2024
17 checks passed
@mmsmits mmsmits deleted the fix/add_check_on_definition_when_visiting branch March 21, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants