2550 parser error ignore customization #2730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion engine factory
…extends a new interface to reflect it
# Conflicts: # src/Hl7.Fhir.Base/Serialization/engine/FhirSerializationEngineFactory.cs # src/Hl7.Fhir.Base/Serialization/engine/PocoSerializationEngine.cs # src/Hl7.Fhir.Support.Poco.Tests/NewPocoSerializers/FhirJsonDeserializationTests.cs
…rter, expanded serialization engine with extra methods to parse standalone objects and elements
# Conflicts: # src/Hl7.Fhir.Support.Poco.Tests/NewPocoSerializers/FhirJsonDeserializationTests.cs
mmsmits
previously requested changes
Mar 12, 2024
ewoutkramer
requested changes
Mar 13, 2024
src/Hl7.Fhir.Base/Serialization/JsonSerializerOptionsExtensions.cs
Outdated
Show resolved
Hide resolved
src/Hl7.Fhir.Base/Serialization/engine/FhirSerializationEngineFactory.cs
Outdated
Show resolved
Hide resolved
src/Hl7.Fhir.Base/Serialization/engine/PocoSerializationEngine.cs
Outdated
Show resolved
Hide resolved
src/Hl7.Fhir.Support.Poco.Tests/NewPocoSerializers/FhirJsonDeserializationTests.cs
Outdated
Show resolved
Hide resolved
src/Hl7.Fhir.Support.Poco.Tests/NewPocoSerializers/FhirJsonDeserializationTests.cs
Outdated
Show resolved
Hide resolved
src/Hl7.Fhir.Support.Poco.Tests/NewPocoSerializers/FhirJsonDeserializationTests.cs
Outdated
Show resolved
Hide resolved
ewoutkramer
requested changes
Mar 19, 2024
| Predicate<CodedException>? ignoreFilter = null) | ||
| internal void SetEnforcedErrors(IEnumerable<string> toEnforce) | ||
| { | ||
| Engine ??= (FhirSerializationEngineFactory.Strict(inspector, serializerSettings, deserializerSettings) as PocoSerializationEngine)!; |
There was a problem hiding this comment.
(x as Y)! suggests you really want ((Y)x) here, which will never return null (and throw if the cast does not work).
|
|
||
| internal void SetIgnoredErrors(IEnumerable<string> toIgnore) | ||
| { | ||
| Engine ??= (FhirSerializationEngineFactory.Strict(inspector, serializerSettings, deserializerSettings) as PocoSerializationEngine)!; |
There was a problem hiding this comment.
Maybe this factory code should be in a small private function, instead of repeating it.
| DisallowSchemaLocation = mode is Mode.Strict, | ||
| PermissiveParsing = mode is Mode.Permissive or Mode.Ostrich, | ||
| ValidateFhirXhtml = mode is Mode.Strict | ||
| DisallowSchemaLocation = mode is Mode.Strict, PermissiveParsing = mode is Mode.Permissive or Mode.Ostrich, ValidateFhirXhtml = mode is Mode.Strict |
| namespace Hl7.Fhir.Serialization; | ||
|
|
||
| public interface IFhirExtendedSerializationEngine : IFhirSerializationEngine | ||
| internal interface IFhirExtendedSerializationEngine : IFhirSerializationEngine |
There was a problem hiding this comment.
I don't think you need this interface anymore?
ewoutkramer
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Closes [#2550].
Testing
Added tests to assert correct behaviour of the error-filtering predicates and their prevalence according to where in the chain they are called