Fixed NullReferenceException when enumerating bundled/contained resources #2858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erating bundled resources if one of the bundle entries did not have fullUrl set
mmsmits
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ScopedNode.ContainedResources() and ScopedNode.BundledResources() should no longer throw an exception when fullUrl or id respectively are not set.
When an entry or contained resource is encountered without these fields set, they are now caught in an overflow list containing all resources which cannot be referenced. These can never be resolved on, so this does not need to be in a dict.
Related issues
FS had issues building with SDK 5.10
Testing
Added new test in ScopedNodeTests so that we do not break this at some point